Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IsEmpty to check for empty value #478

Closed
wants to merge 1 commit into from
Closed

Use IsEmpty to check for empty value #478

wants to merge 1 commit into from

Conversation

NickNaso
Copy link
Member

Use Value::IsEmpty instead check for empty value using the following code:

if (_value == nullptr) {
   // Do something
}

mhdawson
mhdawson approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson pushed a commit that referenced this pull request May 17, 2019
@NickNaso @mhdawson
Use Value::IsEmpty to check for empty value
e1cf9a3 
PR-URL: #478
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@mhdawson
Copy link
Member

Landed as e1cf9a35a1b6edc404c1b465ec94f8a821641059

@mhdawson mhdawson closed this May 17, 2019
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
@kevindavies8
Use Value::IsEmpty to check for empty value
2e1c37b 
PR-URL: nodejs/node-addon-api#478
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
@Marlyfleitas
Use Value::IsEmpty to check for empty value
750f7ae 
PR-URL: nodejs/node-addon-api#478
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
@wroy7860
Use Value::IsEmpty to check for empty value
830df79 
PR-URL: nodejs/node-addon-api#478
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
Use Value::IsEmpty to check for empty value
b548840 
PR-URL: nodejs/node-addon-api#478
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@gabrielschulhof gabrielschulhof gabrielschulhof approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NickNaso @mhdawson @addaleax @gabrielschulhof