Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct return type of Int32Value to int32_t #459

Closed
wants to merge 1 commit into from

Conversation

gallafent
Copy link
Contributor

It currently reads uint32_t, which would be very strange, and is also untrue (I checked napi.h) ;)

It currently reads uint32_t, which would be very strange, and is also untrue (I checked napi.h) ;)
Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson mentioned this pull request Mar 20, 2019
4 tasks
mhdawson pushed a commit that referenced this pull request Mar 20, 2019
It currently reads uint32_t, which would be very strange, and
is also untrue (I checked napi.h) ;)

PR-URL: #459
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: NickNaso <[email protected]>
@mhdawson
Copy link
Member

Thanks ! Landed as 1ed7ad8

@mhdawson mhdawson closed this Mar 20, 2019
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
It currently reads uint32_t, which would be very strange, and
is also untrue (I checked napi.h) ;)

PR-URL: nodejs/node-addon-api#459
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: NickNaso <[email protected]>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
It currently reads uint32_t, which would be very strange, and
is also untrue (I checked napi.h) ;)

PR-URL: nodejs/node-addon-api#459
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: NickNaso <[email protected]>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
It currently reads uint32_t, which would be very strange, and
is also untrue (I checked napi.h) ;)

PR-URL: nodejs/node-addon-api#459
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: NickNaso <[email protected]>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
It currently reads uint32_t, which would be very strange, and
is also untrue (I checked napi.h) ;)

PR-URL: nodejs/node-addon-api#459
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: NickNaso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants