Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix callbackData leaks on error napi status #417

Closed
wants to merge 1 commit into from
Closed

src: fix callbackData leaks on error napi status #417

wants to merge 1 commit into from

Conversation

DaAitch
Copy link
Contributor

@DaAitch DaAitch commented Dec 28, 2018

No description provided.

gabrielschulhof
gabrielschulhof approved these changes Dec 28, 2018
View reviewed changes
Copy link
Contributor

@gabrielschulhof gabrielschulhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you!

NickNaso
NickNaso approved these changes Dec 28, 2018
View reviewed changes
Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson
mhdawson approved these changes Jan 2, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson pushed a commit that referenced this pull request Jan 2, 2019
@DaAitch @mhdawson
src: fix callbackData leaks on error napi status
91eaa6f 
PR-URL: #417
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@mhdawson
Copy link
Member

mhdawson commented Jan 2, 2019

Landed as 91eaa6f

@mhdawson mhdawson closed this Jan 2, 2019
@mhdawson mhdawson mentioned this pull request Oct 10, 2019
Closed
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
@kevindavies8
src: fix callbackData leaks on error napi status
5655d67 
PR-URL: nodejs/node-addon-api#417
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
@Marlyfleitas
src: fix callbackData leaks on error napi status
941e7d5 
PR-URL: nodejs/node-addon-api#417
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
@wroy7860
src: fix callbackData leaks on error napi status
e231356 
PR-URL: nodejs/node-addon-api#417
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
src: fix callbackData leaks on error napi status
12e7e93 
PR-URL: nodejs/node-addon-api#417
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@gabrielschulhof gabrielschulhof gabrielschulhof approved these changes

@NickNaso NickNaso NickNaso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DaAitch @mhdawson @NickNaso @gabrielschulhof