Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Call() instead of MakeCallback() in AsyncWorker #361

Closed
wants to merge 1 commit into from
Closed

Use Call() instead of MakeCallback() in AsyncWorker #361

wants to merge 1 commit into from
+2 −2

Conversation

romandev
Copy link
Contributor

@romandev romandev commented Oct 2, 2018

Change AsyncWorker::OnOK() and AsyncWorker::OnError() callbacks to
NOT use MakeCallback(). An ordinary function call
(_callback::Call()) is now correct.

Refs: https://nodejs.org/api/n-api.html#n_api_napi_make_callback

@romandev
Use Call() instead of MakeCallback() in AsyncWorker
f552652 
Change `AsyncWorker::OnOK()` and `AsyncWorker::OnError()` callbacks to
**NOT** use `MakeCallback()`. An ordinary function call
(`_callback::Call()`) is now correct.

Refs: https://nodejs.org/api/n-api.html#n_api_napi_make_callback
@NickNaso
Copy link
Member

NickNaso commented Oct 2, 2018

I agree with your solution in the AsyncWorker we use napi_create_async_work and in the napi_async_complete_callback the async context is already set up, so it's not necessary use napi_make_callback.

NickNaso
NickNaso approved these changes Oct 2, 2018
View reviewed changes
Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson
mhdawson approved these changes Oct 2, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this is good. Checked 6.x and it seems like we have a backport for CallbackScope and looks like the required pieces are in place.

mhdawson pushed a commit that referenced this pull request Oct 22, 2018
@romandev @mhdawson
src: use MakeCallback() -> Call() in AsyncWorker
fa3a615 
Change `AsyncWorker::OnOK()` and `AsyncWorker::OnError()` callbacks to
**NOT** use `MakeCallback()`. An ordinary function call
(`_callback::Call()`) is now correct.

PR-URL: #361
Refs: https://nodejs.org/api/n-api.html#n_api_napi_make_callback
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Nicola Del Gobbo <[email protected]>
@mhdawson
Copy link
Member

Landed as fa3a615

@mhdawson mhdawson closed this Oct 22, 2018
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
@kevindavies8
src: use MakeCallback() -> Call() in AsyncWorker
6cd48b0 
Change `AsyncWorker::OnOK()` and `AsyncWorker::OnError()` callbacks to
**NOT** use `MakeCallback()`. An ordinary function call
(`_callback::Call()`) is now correct.

PR-URL: nodejs/node-addon-api#361
Refs: https://nodejs.org/api/n-api.html#n_api_napi_make_callback
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Nicola Del Gobbo <[email protected]>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
@Marlyfleitas
src: use MakeCallback() -> Call() in AsyncWorker
0b94f9a 
Change `AsyncWorker::OnOK()` and `AsyncWorker::OnError()` callbacks to
**NOT** use `MakeCallback()`. An ordinary function call
(`_callback::Call()`) is now correct.

PR-URL: nodejs/node-addon-api#361
Refs: https://nodejs.org/api/n-api.html#n_api_napi_make_callback
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Nicola Del Gobbo <[email protected]>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
@wroy7860
src: use MakeCallback() -> Call() in AsyncWorker
7dd03ac 
Change `AsyncWorker::OnOK()` and `AsyncWorker::OnError()` callbacks to
**NOT** use `MakeCallback()`. An ordinary function call
(`_callback::Call()`) is now correct.

PR-URL: nodejs/node-addon-api#361
Refs: https://nodejs.org/api/n-api.html#n_api_napi_make_callback
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Nicola Del Gobbo <[email protected]>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
src: use MakeCallback() -> Call() in AsyncWorker
3a5b3a4 
Change `AsyncWorker::OnOK()` and `AsyncWorker::OnError()` callbacks to
**NOT** use `MakeCallback()`. An ordinary function call
(`_callback::Call()`) is now correct.

PR-URL: nodejs/node-addon-api#361
Refs: https://nodejs.org/api/n-api.html#n_api_napi_make_callback
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Nicola Del Gobbo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@gabrielschulhof gabrielschulhof gabrielschulhof approved these changes

@NickNaso NickNaso NickNaso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@romandev @NickNaso @mhdawson @gabrielschulhof