Added .npmrc for setting package-lock to false #359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```npm install``` creates a ```package-lock.json``` to lock the versions of dependencies that are installed. They recommend to commit this file and that's what I usually do in other projects but I think we should gitignore it in CITGM. This will allow us to always test the latest version of our dependencies (especially in CI).
|
I was thinking at same thing, but my solution was to eliminate the |
|
I agree with your opinion ~. :) |
|
What do you think it? @mhdawson @gabrielschulhof |
|
+1 from me. |
|
Hi @nodejs/n-api can @yjaeseok continue to go forward with his proposal? Is there any objection? |
|
fwiw using package-lock.json in any library doesn't make sense because npm doesn't use it in that context. it should just be removed completely anyway. |
|
Hi @yjaeseok, I think that there are not objections about you PR so please if you need to complete something do it and then just ping here to get a review. |
yjaeseok
changed the title
|
@NickNaso I updated it as you mention, Please review again :) |
thefourtheye
approved these changes
Oct 11, 2018
mhdawson
pushed a commit
that referenced
this pull request
Oct 22, 2018
```npm install``` creates a ```package-lock.json``` to lock the versions of dependencies that are installed. They recommend to commit this file and that's what I usually do in other projects but we should not use it for this project. This will allow us to always test the latest version of our dependencies (especially in CI). PR-URL: #359 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Nicola Del Gobbo <[email protected]>
|
Landed as 8ce605c |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
```npm install``` creates a ```package-lock.json``` to lock the versions of dependencies that are installed. They recommend to commit this file and that's what I usually do in other projects but we should not use it for this project. This will allow us to always test the latest version of our dependencies (especially in CI). PR-URL: nodejs/node-addon-api#359 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Nicola Del Gobbo <[email protected]>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
```npm install``` creates a ```package-lock.json``` to lock the versions of dependencies that are installed. They recommend to commit this file and that's what I usually do in other projects but we should not use it for this project. This will allow us to always test the latest version of our dependencies (especially in CI). PR-URL: nodejs/node-addon-api#359 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Nicola Del Gobbo <[email protected]>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
```npm install``` creates a ```package-lock.json``` to lock the versions of dependencies that are installed. They recommend to commit this file and that's what I usually do in other projects but we should not use it for this project. This will allow us to always test the latest version of our dependencies (especially in CI). PR-URL: nodejs/node-addon-api#359 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Nicola Del Gobbo <[email protected]>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
```npm install``` creates a ```package-lock.json``` to lock the versions of dependencies that are installed. They recommend to commit this file and that's what I usually do in other projects but we should not use it for this project. This will allow us to always test the latest version of our dependencies (especially in CI). PR-URL: nodejs/node-addon-api#359 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Nicola Del Gobbo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm installcreates apackage-lock.jsonto lock the versions of dependencies that are installed.They recommend to commit this file and that's what I usually do in other projects but I think we should gitignore it in CITGM.
This will allow us to always test the latest version of our dependencies (especially in CI).