Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for publish to npm #33

Merged
merged 1 commit into from
May 4, 2017
Merged

Prepare for publish to npm #33

merged 1 commit into from
May 4, 2017

Conversation

jasongin
Copy link
Member

@jasongin jasongin commented May 2, 2017

  • Change package name from "node-api" to "node-addon-api"
  • Add license file
  • Add contributors list to package.json and readme
  • Add preliminary doc link to readme

 - Change package name from "node-api" to "node-addon-api"
 - Add license file
 - Add contributors list to package.json and readme
 - Add preliminary doc link to readme
@jasongin
Copy link
Member Author

jasongin commented May 3, 2017

@mhdawson Should we also rename this repo to node-addon-api?

Copy link

@boingoing boingoing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasongin
Copy link
Member Author

jasongin commented May 4, 2017

Fixes: nodejs/abi-stable-node#223

@jasongin jasongin merged commit 9d46bcb into nodejs:master May 4, 2017
@jasongin jasongin deleted the package2 branch May 4, 2017 23:37
@jasongin
Copy link
Member Author

jasongin commented May 4, 2017

Published at https://www.npmjs.com/package/node-addon-api

I also added nodejs-foundation as a package owner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants