Objectwrap and ClassPropertyDescriptor documentation #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhdawson
reviewed
Sep 6, 2018
doc/object_wrap.md
Outdated
| InstanceMethod("SetValue", &Example::SetValue) | ||
| }); | ||
|
|
||
| constructor = Napi::Persistent(func); |
There was a problem hiding this comment.
Some comments here that talk about how the persistent is used and why suppress destruct is needed would be good.
There was a problem hiding this comment.
Ok it's reasonable give more explanation about this.
mhdawson
reviewed
Sep 6, 2018
doc/object_wrap.md
Outdated
| }; | ||
|
|
||
| Napi::Object Example::Init(Napi::Env env, Napi::Object exports) { | ||
| Napi::HandleScope scope(env); |
There was a problem hiding this comment.
Is the handle scope needed here? I'm not sure but worth checking
There was a problem hiding this comment.
No it's not necessary I will remove it. (I tested the example without handle scope).
|
Ran out of time today, will try to add more comments tomorrow. |
NickNaso
changed the title
mhdawson
pushed a commit
that referenced
this pull request
Sep 18, 2018
PR-URL: #321 Reviewed-By: Michael Dawson <[email protected]>
|
Landed as 100d0a7 |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
PR-URL: nodejs/node-addon-api#321 Reviewed-By: Michael Dawson <[email protected]>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
PR-URL: nodejs/node-addon-api#321 Reviewed-By: Michael Dawson <[email protected]>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
PR-URL: nodejs/node-addon-api#321 Reviewed-By: Michael Dawson <[email protected]>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
PR-URL: nodejs/node-addon-api#321 Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
I just start on writing documentation for
Napi::ObjectWrapplease review and suggest me some changes and possible improvements.