Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: minor typos #248

Closed
wants to merge 1 commit into from
Closed

docs: minor typos #248

wants to merge 1 commit into from

Conversation

iSkore
Copy link
Contributor

@iSkore iSkore commented Apr 26, 2018

just some small typos in the docs
renamed doc/onject_lifetime_management.md to doc/object_lifetime_management.md

just some small typos in the docs
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson pushed a commit that referenced this pull request May 30, 2018
Fix some small typos in the docs.

PR-URL: #248
Reviewed-By: Michael Dawson <[email protected]>
@mhdawson
Copy link
Member

Landed as b197f7c

@mhdawson mhdawson closed this May 30, 2018
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
Fix some small typos in the docs.

PR-URL: nodejs/node-addon-api#248
Reviewed-By: Michael Dawson <[email protected]>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
Fix some small typos in the docs.

PR-URL: nodejs/node-addon-api#248
Reviewed-By: Michael Dawson <[email protected]>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
Fix some small typos in the docs.

PR-URL: nodejs/node-addon-api#248
Reviewed-By: Michael Dawson <[email protected]>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
Fix some small typos in the docs.

PR-URL: nodejs/node-addon-api#248
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants