Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n-api: fix memory leak in napi_async_destroy() #213

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
n-api: fix memory leak in napi_async_destroy()
This is a cherry-pick patch from upstream[1].

[1] nodejs/node@87cb1f5
romandev committed Jan 14, 2018
commit d5c171e47c6c6d7b5be39082a83bc81d5029a9e4
2 changes: 2 additions & 0 deletions src/node_api.cc
Original file line number Diff line number Diff line change
@@ -2855,6 +2855,8 @@ napi_status napi_async_destroy(napi_env env,
reinterpret_cast<node::async_context*>(async_context);
node::EmitAsyncDestroy(isolate, *node_async_context);

delete node_async_context;

return napi_clear_last_error(env);
}