Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start documentation #192

Closed
wants to merge 1 commit into from
Closed

Start documentation #192

wants to merge 1 commit into from

Conversation

NickNaso
Copy link
Member

Start work on documentation

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson pushed a commit that referenced this pull request Nov 23, 2017
PR-URL: #192
Reviewed-By: Michael Dawson <[email protected]>
@mhdawson
Copy link
Member

Landed as 5543c01

@addaleax
Copy link
Member

Uh … this was merged fast.

@NickNaso How is this documentation going to differ from https://nodejs.github.io/node-addon-api/ ?

@NickNaso
Copy link
Member Author

NickNaso commented Nov 23, 2017

Hi @addaleax,
we are writing the documentation through markdown. We started to organize the readme and to split the documentation in different sections. It's only the start. At the end of writing we will use the markdown file to generate a documentation web site to publish on https://nodejs.github.io/node-addon-api/.
I really want go aver the normal documentation reference and explain in a more expressive way how to use some API provided by the node-addon-api
I hope that you share the idea and if you want propose yours it will be great

@addaleax
Copy link
Member

I really want go aver the normal documentation reference and explain in a more expressive way how to use some API provided by the node-addon-api

I am very much a fan of that! What I’m asking is why we’re not integrating that with the existing API documentation, which is rather complete and pretty useful imo?

@NickNaso
Copy link
Member Author

NickNaso commented Nov 23, 2017

At the end we need combining both maybe like proposed here:
nodejs/abi-stable-node#280 (comment)
Personally I'm thinking on how to do that even if I haven't a clear idea on how to do that.

@mhdawson
Copy link
Member

mhdawson commented Nov 24, 2017

@addaleax the main reason in my mind that we might not integrate with the existing API doc (and why I've not thought of doing that) is that node-addon-api is not "officially" part of Node.js. It's a helper module that happens to be provided by the Node.js community.

Having said that, I'm not opposed to integrating if we think that's the right thing to do.

In terms of this PR landing fast, it was opened to replace #182 which had been open for quite a while. We could just not get it into a form that we could land. Of course we missed adding that context to this PR which would have been good.

@addaleax
Copy link
Member

addaleax commented Nov 25, 2017

@mhdawson Just to make sure we’re talking about the same thing: When I said “existing” documentation, I was referring to the linked https://nodejs.github.io/node-addon-api/ (i.e. documentation for this very module), not the docs for the C interface that are part of Node.

kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants