-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start documentation #192
Start documentation #192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR-URL: #192 Reviewed-By: Michael Dawson <[email protected]>
Landed as 5543c01 |
Uh … this was merged fast. @NickNaso How is this documentation going to differ from https://nodejs.github.io/node-addon-api/ ? |
Hi @addaleax, |
I am very much a fan of that! What I’m asking is why we’re not integrating that with the existing API documentation, which is rather complete and pretty useful imo? |
At the end we need combining both maybe like proposed here: |
@addaleax the main reason in my mind that we might not integrate with the existing API doc (and why I've not thought of doing that) is that node-addon-api is not "officially" part of Node.js. It's a Having said that, I'm not opposed to integrating if we think that's the right thing to do. In terms of this PR landing fast, it was opened to replace #182 which had been open for quite a while. We could just not get it into a form that we could land. Of course we missed adding that context to this PR which would have been good. |
@mhdawson Just to make sure we’re talking about the same thing: When I said “existing” documentation, I was referring to the linked https://nodejs.github.io/node-addon-api/ (i.e. documentation for this very module), not the docs for the C interface that are part of Node. |
PR-URL: nodejs/node-addon-api#192 Reviewed-By: Michael Dawson <[email protected]>
PR-URL: nodejs/node-addon-api#192 Reviewed-By: Michael Dawson <[email protected]>
PR-URL: nodejs/node-addon-api#192 Reviewed-By: Michael Dawson <[email protected]>
PR-URL: nodejs/node-addon-api#192 Reviewed-By: Michael Dawson <[email protected]>
Start work on documentation