Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use eslint directly #1616

Merged
merged 1 commit into from
Nov 15, 2024
Merged

chore: use eslint directly #1616

merged 1 commit into from
Nov 15, 2024

Conversation

legendecas
Copy link
Member

tools/eslint-format was not failed on #1613 but failed on the main branch.

Since the diff on applying the eslint is trivial, let's apply eslint on all files.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.35%. Comparing base (cc2b8df) to head (789dacc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1616   +/-   ##
=======================================
  Coverage   66.35%   66.35%           
=======================================
  Files           3        3           
  Lines        2143     2143           
  Branches      703      703           
=======================================
  Hits         1422     1422           
  Misses        150      150           
  Partials      571      571           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KevinEady
Copy link
Contributor

Hmm, should the formatting changes have been found in our "format everything" branch #1160 ? Or were there new rules added since 1160 landed (May 2022)?

@legendecas
Copy link
Member Author

legendecas commented Nov 13, 2024

#1613 updated the eslint and plugins version. However, tools/eslint-format only checks on JS files changed in a PR -- where #1613 didn't change any JS files. eslint-format does not apply new eslint and plugins on existing files.

Both standard and neostandard have the rule 'object-shorthand' in their new versions.

Copy link
Contributor

@KevinEady KevinEady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit 504133b into nodejs:main Nov 15, 2024
54 checks passed
@legendecas legendecas deleted the fix-lint branch November 16, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants