Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: enable type cast checks in tests #1581

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Sep 27, 2024

Fixes: #1575

BEGIN_COMMIT_OVERRIDE
fix: failed type cast checks in Symbol::WellKnown (#1581)
END_COMMIT_OVERRIDE

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legendecas legendecas merged commit d8523a7 into nodejs:main Oct 3, 2024
48 checks passed
@legendecas legendecas deleted the check-cast branch October 3, 2024 09:42
@github-actions github-actions bot mentioned this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Symbol::WellKnown fails in Object::CheckCast when NODE_ADDON_API_ENABLE_TYPE_CHECK_ON_AS is defined
2 participants