Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v7.0.0 #1336

Merged
merged 1 commit into from
Jun 14, 2023
Merged

release: v7.0.0 #1336

merged 1 commit into from
Jun 14, 2023

Conversation

KevinEady
Copy link
Contributor

Update package and documentation for release v7.0.0 according to Creating a Release

@KevinEady
Copy link
Contributor Author

@NickNaso should the CI jobs be ran on main once this is merged or is it sufficient to run on this PR? I was planning on the former but I see you started some jobs 😄

@NickNaso
Copy link
Member

NickNaso commented Jun 13, 2023

@KevinEady Yes I saw you updates and all seems good so I ran the CI. My purpose is to discover some errors before the merge. I think that we should also run the CI on main after the merge of the PR.

Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KevinEady
Copy link
Contributor Author

Merging after 24h with only one approval to complete release

@KevinEady KevinEady merged commit 39a25bf into nodejs:main Jun 14, 2023
@KevinEady KevinEady deleted the release-v7.0.0 branch June 14, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants