test: fix compilation problem on debian 8. #1138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First pass on CI: |
|
Second pass on CI: |
addaleax
approved these changes
Feb 21, 2022
test/objectwrap_function.cc
Outdated
| @@ -36,7 +36,8 @@ class FunctionTest : public Napi::ObjectWrap<FunctionTest> { | |||
| }; | |||
|
|
|||
| std::unordered_map<napi_env, Napi::FunctionReference> | |||
| FunctionTest::constructors = {}; | |||
| FunctionTest::constructors = | |||
| std::unordered_map<napi_env, Napi::FunctionReference>(); | |||
There was a problem hiding this comment.
I think just dropping the = or the = {} would also do the trick here
There was a problem hiding this comment.
That's what I just tested out, removing the = {}
mhdawson
reviewed
Feb 21, 2022
mhdawson
reviewed
Feb 21, 2022
|
Going to land as soon as the github actions complete |
mhdawson
pushed a commit
that referenced
this pull request
Feb 21, 2022
PR-URL: #1138 Reviewed-By: Michael Dawson <[email protected] Reviewed-By: Anna Henningsen <[email protected]>
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
PR-URL: nodejs/node-addon-api#1138 Reviewed-By: Michael Dawson <[email protected] Reviewed-By: Anna Henningsen <[email protected]>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
PR-URL: nodejs/node-addon-api#1138 Reviewed-By: Michael Dawson <[email protected] Reviewed-By: Anna Henningsen <[email protected]>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
PR-URL: nodejs/node-addon-api#1138 Reviewed-By: Michael Dawson <[email protected] Reviewed-By: Anna Henningsen <[email protected]>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
PR-URL: nodejs/node-addon-api#1138 Reviewed-By: Michael Dawson <[email protected] Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1137