Add test case for Object Set using uint32 as key #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JckXia
requested changes
Feb 13, 2022
|
My mistake, just modified. |
|
@meixg The change looks good! Thanks for working on this one. We currently have some issues with our CI but that should hopefully clear up soon. |
|
@meixg We've made a change to our windows CI that should unblock this PR. Please pull in the latest changes and push again. Thanks! |
JckXia
approved these changes
Feb 17, 2022
|
@JckXia CI passed. |
|
Landed as |
|
Thanks for the contribution. And if you are interested in joining our weekly meetings on Friday at 11ET please feel free to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covered
template void Set(uint32_t index, const ValueType& value)Other testings for Object (#936) may have already been covered:
https://github.com/nodejs/node-addon-api/blob/main/test/object/object.cc#L234:
PropertyLValuestd::string operator [](const char* utf8name)
PropertyLValuestd::string operator [](const std::string& utf8name)
PropertyLValue<uint32_t> operator [](uint32_t index)
Object::PropertyLValue (Uncovered)
https://github.com/nodejs/node-addon-api/blob/main/test/object/has_property.cc#L26:
bool Has(uint32_t index) const
https://github.com/nodejs/node-addon-api/blob/main/test/object/get_property.cc#L18:
Value Get(uint32_t index) const
https://github.com/nodejs/node-addon-api/blob/main/test/object/delete_property.cc#L6:
bool Delete(uint32_t index)
https://github.com/nodejs/node-addon-api/blob/main/test/object/object.cc#L280:
bool InstanceOf(const Function& constructor) const