src,test: Fix up null char * exception thrown #1019
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throw an exception when receiving a null pointer for the `char *` and `char16_t *` overloads of `String::New` that looks identical to an error that core would have thrown under the circumstances (`napi_invalid_arg`). Also, rename the test methods to conform with our naming convention.
|
@NickNaso let's please land this before the next node-addon-api release so we release with the correct error message. |
gabrielschulhof
requested review from
KevinEady,
legendecas,
mhdawson and
NickNaso
legendecas
approved these changes
Jul 14, 2021
NickNaso
approved these changes
Jul 14, 2021
gabrielschulhof
added a commit
that referenced
this pull request
Jul 16, 2021
Throw an exception when receiving a null pointer for the `char *` and `char16_t *` overloads of `String::New` that looks identical to an error that core would have thrown under the circumstances (`napi_invalid_arg`). Also, rename the test methods to conform with our naming convention. PR-URL: #1019 Reviewed-By: Nicola Del Gobbo <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
|
Landed in 6697c51. |
deepakrkris
pushed a commit
to deepakrkris/node-addon-api
that referenced
this pull request
Sep 23, 2021
Throw an exception when receiving a null pointer for the `char *` and `char16_t *` overloads of `String::New` that looks identical to an error that core would have thrown under the circumstances (`napi_invalid_arg`). Also, rename the test methods to conform with our naming convention. PR-URL: nodejs#1019 Reviewed-By: Nicola Del Gobbo <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
deepakrkris
pushed a commit
to deepakrkris/node-addon-api
that referenced
this pull request
Oct 15, 2021
Throw an exception when receiving a null pointer for the `char *` and `char16_t *` overloads of `String::New` that looks identical to an error that core would have thrown under the circumstances (`napi_invalid_arg`). Also, rename the test methods to conform with our naming convention. PR-URL: nodejs#1019 Reviewed-By: Nicola Del Gobbo <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Throw an exception when receiving a null pointer for the `char *` and `char16_t *` overloads of `String::New` that looks identical to an error that core would have thrown under the circumstances (`napi_invalid_arg`). Also, rename the test methods to conform with our naming convention. PR-URL: nodejs/node-addon-api#1019 Reviewed-By: Nicola Del Gobbo <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Throw an exception when receiving a null pointer for the `char *` and `char16_t *` overloads of `String::New` that looks identical to an error that core would have thrown under the circumstances (`napi_invalid_arg`). Also, rename the test methods to conform with our naming convention. PR-URL: nodejs/node-addon-api#1019 Reviewed-By: Nicola Del Gobbo <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Throw an exception when receiving a null pointer for the `char *` and `char16_t *` overloads of `String::New` that looks identical to an error that core would have thrown under the circumstances (`napi_invalid_arg`). Also, rename the test methods to conform with our naming convention. PR-URL: nodejs/node-addon-api#1019 Reviewed-By: Nicola Del Gobbo <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Throw an exception when receiving a null pointer for the `char *` and `char16_t *` overloads of `String::New` that looks identical to an error that core would have thrown under the circumstances (`napi_invalid_arg`). Also, rename the test methods to conform with our naming convention. PR-URL: nodejs/node-addon-api#1019 Reviewed-By: Nicola Del Gobbo <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw an exception when receiving a null pointer for the
char *andchar16_t *overloads ofString::Newthat looks identical to anerror that core would have thrown under the circumstances
(
napi_invalid_arg).Also, rename the test methods to conform with our naming convention.