New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: rename N-API with Node-API on comments #952

Closed

NickNaso opened this issue Mar 25, 2021 · 1 comment

Member

NickNaso commented Mar 25, 2021

Refs: nodejs/abi-stable-node#420
It's necessary to rename N-API with Node-API all over the comments in the source code.

NickNaso mentioned this issue

src: rename N-API with Node-API on comments #953

Closed

Member Author

NickNaso commented Mar 25, 2021

PR: #953

gabrielschulhof closed this as completed in

deepakrkris pushed a commit to deepakrkris/node-addon-api that referenced this issue


          src: rename N-API with Node-API on comments

Also fixed lint errors.

Fixes: nodejs#952
PR-URL: nodejs#953
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>

deepakrkris pushed a commit to deepakrkris/node-addon-api that referenced this issue


          src: rename N-API with Node-API on comments

5c5d885

Also fixed lint errors.

Fixes: nodejs#952
PR-URL: nodejs#953
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>

kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this issue


          src: rename N-API with Node-API on comments

662e4f4

Also fixed lint errors.

Fixes: nodejs/node-addon-api#952
PR-URL: nodejs/node-addon-api#953
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>

Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this issue


          src: rename N-API with Node-API on comments

ce500e6

Also fixed lint errors.

Fixes: nodejs/node-addon-api#952
PR-URL: nodejs/node-addon-api#953
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>

wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this issue


          src: rename N-API with Node-API on comments

31c9fbf

Also fixed lint errors.

Fixes: nodejs/node-addon-api#952
PR-URL: nodejs/node-addon-api#953
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>

johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this issue


          src: rename N-API with Node-API on comments

f8294e6

Also fixed lint errors.

Fixes: nodejs/node-addon-api#952
PR-URL: nodejs/node-addon-api#953
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment