Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: rename N-API to Node-API #950

Closed
NickNaso opened this issue Mar 25, 2021 · 1 comment
Closed

doc: rename N-API to Node-API #950

NickNaso opened this issue Mar 25, 2021 · 1 comment
Labels
doc good first issue

Comments

@NickNaso
Copy link
Member

Refs: nodejs/abi-stable-node#420
It's necessary to rename N-API with Node-API all over the documentation.
RaisinTen added a commit to RaisinTen/node-addon-api that referenced this issue Mar 25, 2021
@RaisinTen
doc: rename N-API with Node-API
1980f06 
Done by running:
sed -i "s/N-API/Node-API/g" doc/*

Fixes: nodejs#950
@RaisinTen RaisinTen mentioned this issue Mar 25, 2021
Closed
@RaisinTen
Copy link
Contributor

PR: #951

deepakrkris pushed a commit to deepakrkris/node-addon-api that referenced this issue Sep 23, 2021
@RaisinTen
doc: rename N-API with Node-API
22c67da 
Done by running:
sed -i "s/N-API/Node-API/g" doc/*
sed -i "s/N-API/Node-API/g" README.md CONTRIBUTING.md

Fixes: nodejs#950
PR-URL: nodejs#951
Reviewed-By: Nicola Del Gobbo <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
deepakrkris pushed a commit to deepakrkris/node-addon-api that referenced this issue Oct 15, 2021
@RaisinTen
doc: rename N-API with Node-API
91c9861 
Done by running:
sed -i "s/N-API/Node-API/g" doc/*
sed -i "s/N-API/Node-API/g" README.md CONTRIBUTING.md

Fixes: nodejs#950
PR-URL: nodejs#951
Reviewed-By: Nicola Del Gobbo <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this issue Aug 24, 2022
@kevindavies8
doc: rename N-API with Node-API
e981f0b 
Done by running:
sed -i "s/N-API/Node-API/g" doc/*
sed -i "s/N-API/Node-API/g" README.md CONTRIBUTING.md

Fixes: nodejs/node-addon-api#950
PR-URL: nodejs/node-addon-api#951
Reviewed-By: Nicola Del Gobbo <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this issue Aug 26, 2022
@Marlyfleitas
doc: rename N-API with Node-API
1f71749 
Done by running:
sed -i "s/N-API/Node-API/g" doc/*
sed -i "s/N-API/Node-API/g" README.md CONTRIBUTING.md

Fixes: nodejs/node-addon-api#950
PR-URL: nodejs/node-addon-api#951
Reviewed-By: Nicola Del Gobbo <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this issue Sep 19, 2022
@wroy7860
doc: rename N-API with Node-API
fdbc280 
Done by running:
sed -i "s/N-API/Node-API/g" doc/*
sed -i "s/N-API/Node-API/g" README.md CONTRIBUTING.md

Fixes: nodejs/node-addon-api#950
PR-URL: nodejs/node-addon-api#951
Reviewed-By: Nicola Del Gobbo <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@baby636 baby636 mentioned this issue Jun 5, 2023
Open
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this issue Aug 11, 2023
doc: rename N-API with Node-API
56a9b57 
Done by running:
sed -i "s/N-API/Node-API/g" doc/*
sed -i "s/N-API/Node-API/g" README.md CONTRIBUTING.md

Fixes: nodejs/node-addon-api#950
PR-URL: nodejs/node-addon-api#951
Reviewed-By: Nicola Del Gobbo <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: rename N-API with Node-API RaisinTen/node-addon-api
2 participants
@NickNaso @RaisinTen