Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] undocumented method(s) on Object. #614

Closed
zander opened this issue Nov 30, 2019 · 0 comments · Fixed by #615
Closed

[Docs] undocumented method(s) on Object. #614

zander opened this issue Nov 30, 2019 · 0 comments · Fixed by #615

Comments

@zander
Copy link

zander commented Nov 30, 2019

Looking at https://github.com/nodejs/node-addon-api/blob/master/doc/object.md

I failed to find a way to iterate over properties. I eventually found it via the napi docs and the addon implementation files.

Would be nice if the docs can be complete.

Napi::Object::GetPropertyNames() is not listed in the API docs.

Napi::Object::HasOwnProperty() is not listed in the API docs.

Napi::Object::Delete() is not listed in the API docs.
tniessen added a commit to tniessen/node-addon-api that referenced this issue Nov 30, 2019
@tniessen
Add GetPropertyNames, HasOwnProperty, Delete
026d3d0 
Fixes: nodejs#614
tniessen added a commit to tniessen/node-addon-api that referenced this issue Nov 30, 2019
@tniessen
Add GetPropertyNames, HasOwnProperty, Delete
e369a10 
Fixes: nodejs#614
@tniessen tniessen mentioned this issue Nov 30, 2019
Merged
mhdawson pushed a commit that referenced this issue Dec 5, 2019
@tniessen @mhdawson
Add GetPropertyNames, HasOwnProperty, Delete (#615)
c584343 
Fixes: #614

PR-URL: #615
Fixes: #614
Reviewed-By: NickNaso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this issue Aug 24, 2022
@kevindavies8
Add GetPropertyNames, HasOwnProperty, Delete (#615)
8289a28 
Fixes: nodejs/node-addon-api#614

PR-URL: nodejs/node-addon-api#615
Fixes: nodejs/node-addon-api#614
Reviewed-By: NickNaso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this issue Aug 26, 2022
@Marlyfleitas
Add GetPropertyNames, HasOwnProperty, Delete (#615)
4f8bab1 
Fixes: nodejs/node-addon-api#614

PR-URL: nodejs/node-addon-api#615
Fixes: nodejs/node-addon-api#614
Reviewed-By: NickNaso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this issue Sep 19, 2022
@wroy7860
Add GetPropertyNames, HasOwnProperty, Delete (#615)
a376097 
Fixes: nodejs/node-addon-api#614

PR-URL: nodejs/node-addon-api#615
Fixes: nodejs/node-addon-api#614
Reviewed-By: NickNaso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this issue Aug 11, 2023
Add GetPropertyNames, HasOwnProperty, Delete (#615)
1a8ed3f 
Fixes: nodejs/node-addon-api#614

PR-URL: nodejs/node-addon-api#615
Fixes: nodejs/node-addon-api#614
Reviewed-By: NickNaso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add GetPropertyNames, HasOwnProperty, Delete tniessen/node-addon-api
1 participant
@zander