Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up on adding JS linter #1076

Closed
rubiagatra opened this issue Sep 22, 2021 · 2 comments
Closed

Follow up on adding JS linter #1076

rubiagatra opened this issue Sep 22, 2021 · 2 comments

Comments

@rubiagatra
Copy link
Contributor

rubiagatra commented Sep 22, 2021 •
edited
Loading

This is a follow-up from #1063

Notes Move out to PR
@rubiagatra
Copy link
Contributor Author

Is the issue description something like this @mhdawson?

@mhdawson
Copy link
Member

@rubiagatra thanks for creating, updated the Notes to match what I had in mind.

@rubiagatra rubiagatra mentioned this issue Sep 29, 2021
Closed
2 tasks
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this issue Aug 24, 2022
@kevindavies8
test: create tools/eslint-format
e9735af 
Improve JS linting and add option to fix linting errors

Fixes: nodejs/node-addon-api#1076
PR-URL: nodejs/node-addon-api#1080
Reviewed-By: Michael Dawson <[email protected]
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this issue Aug 26, 2022
@Marlyfleitas
test: create tools/eslint-format
c764825 
Improve JS linting and add option to fix linting errors

Fixes: nodejs/node-addon-api#1076
PR-URL: nodejs/node-addon-api#1080
Reviewed-By: Michael Dawson <[email protected]
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this issue Sep 19, 2022
@wroy7860
test: create tools/eslint-format
ca751c0 
Improve JS linting and add option to fix linting errors

Fixes: nodejs/node-addon-api#1076
PR-URL: nodejs/node-addon-api#1080
Reviewed-By: Michael Dawson <[email protected]
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this issue Aug 11, 2023
test: create tools/eslint-format
58b2329 
Improve JS linting and add option to fix linting errors

Fixes: nodejs/node-addon-api#1076
PR-URL: nodejs/node-addon-api#1080
Reviewed-By: Michael Dawson <[email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

create tools/eslint-format
2 participants
@rubiagatra @mhdawson