Add variant of Nan::New<v8::String> which takes a C++17 string_view #880
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
Nan::New<v8::String>(std::string_view)
, which makes it easier to handle compile time known strings.In order to maintan backwards compatibility to C++11, a
NAN_HAS_CPLUSPLUS_17
macro is added (which will also be needed for my next PRs), the code is wrapped intoNAN_ENABLE_STRING_VIEW
guards. If the user wishes to disable the usage of string_view, it can be disabled via adding a define-DNAN_ENABLE_STRING_VIEW=false
, otherwise it is automatically enabled if it's supported by the C++ runtime (C++17 and up)