-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Node to 5.2.0 #76
Conversation
The Docker files looks solid to me, however we only keep the latest version of each supported major version on the repo. So rather than add a new 5.2 directory we just rename 5.1 and update the Also, when updating the latest stable version, the Docker Registry updater file needs to be changed https://github.com/nodejs/docker-node/blob/master/generate-stackbrew-library.sh#L8 |
686bbb9
to
5d433ec
Compare
@Starefossen thanks for the feedback. Rebased against master and pushed a new commit. |
Thanks 👍 Merged. |
Now, clone https://github.com/docker-library/official-images and from the docker-node repo run the following command before submitting a PR back to the official-images repo.
|
Thanks for merging. I gotta run -- suggest someone else does above unless a few hours of wait is ok. |
Related: nodejs/node#4181 Related: nodejs/docker-node#76 Signed-off-by: Hans Kristian Flaatten <[email protected]>
PR to the official registry submitted 😄 |
v5.2.0 is now live on Docker Hub ✨🐳🐢🚀✨ |
Related: nodejs/node#4181 Related: nodejs/docker-node#76 Signed-off-by: Hans Kristian Flaatten <[email protected]>
Related: nodejs/node#4181 Related: nodejs/docker-node#76 Signed-off-by: Hans Kristian Flaatten <[email protected]>
Because its new. Assume I screwed this PR up! :)