Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default shell for alpine images #1380

Closed
wants to merge 1 commit into from

Conversation

damiankoper
Copy link

npm defaults shell and script-shell config settings to bash, which is not available in alpine image.
Npm 7 respects this setting and tries to call bash -c 'git rev-parse ...' while trying to install package directly from git.

Fixes #1378

@LaurentGoderre
Copy link
Member

The change looks good but would it be possible to exclude the Yarn and signature key changes from the PR?

@damiankoper
Copy link
Author

Sure. I ran ./update.sh and thought that's ok.
Ready to go.

@SimenB
Copy link
Member

SimenB commented Oct 27, 2020

FWIW, I don't think it should be up to the docker image to tell npm not to "misbehave". Then again, this isn't a huge burden for us, so 🤷

/cc @nodejs/npm thoughts?

@ruyadorno
Copy link
Member

Checked with the team and it does sounds like the default should be sh instead, we'll fix it soon 😊 thanks for the heads up @SimenB

@PeterDaveHello
Copy link
Member

@ruyadorno thanks! Please let us know when it's fixed, so we can close this issue ;)

@ruyadorno
Copy link
Member

ruyadorno commented Nov 4, 2020

@PeterDaveHello the fix went out in the [email protected] release which has already been merged to node master and is going out in the [email protected] release: nodejs/node#35948 let me know once that's out if all related issues are solved 😊

@PeterDaveHello
Copy link
Member

Sure, thanks @ruyadorno

@nschonni
Copy link
Member

nschonni commented Nov 5, 2020

Closing as the 15.1.0 images have been pushed to the docker hub

@nschonni nschonni closed this Nov 5, 2020
@SimenB
Copy link
Member

SimenB commented Nov 5, 2020

For reference: npm/cli#2067

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Last alpine image breaks npm install with git+ssh
6 participants