-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add abnormal termination step 1 #344
Conversation
63da600
to
b054c98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We probably need more info in this section as well as we should explain how you can use the stack traces for debugging. |
@@ -1 +1,15 @@ | |||
//TODO | |||
# Using `--trace-exit` CLI Option |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Using `--trace-exit` CLI Option | |
# Using Exit Stack Traces for Debugging | |
//TODO | |
# Using `--trace-exit` CLI Option |
@mhdawson PTAL again :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM with a few comments.
``` | ||
|
||
With the knowledge of where the calls of `process.exit` is, we can check around | ||
the invocation to guess the reasons and prevent it from abnormal exits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a huge fan of using the word guess
here. The whole point of using instrumentation is to empower users to make informed decisions instead of guessing why things are not working.
the invocation to guess the reasons and prevent it from abnormal exits. | |
the invocation to understand the reasons and prevent it from abnormal exits. |
With the knowledge of where the calls of `process.exit` is, we can check around | ||
the invocation to guess the reasons and prevent it from abnormal exits. | ||
|
||
Or if we find there is no such prints on process exits, we can come to a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or if we find there is no such prints on process exits, we can come to a | |
If the process doesn't output a stack trace on exit, we can come to a |
the invocation to guess the reasons and prevent it from abnormal exits. | ||
|
||
Or if we find there is no such prints on process exits, we can come to a | ||
conclusion that the process may exited for some other obscure reasons, and we |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conclusion that the process may exited for some other obscure reasons, and we | |
conclusion that the process exited for other reasons, and we |
|
||
Or if we find there is no such prints on process exits, we can come to a | ||
conclusion that the process may exited for some other obscure reasons, and we | ||
have to deploy following steps of the Abnormal Termination guides. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
, and we have to deploy following steps of the Abnormal Termination guides.
This is vague, I'd rather point the user to specific guides based on symptoms. Might be worth leaving that last part out or leaving a placeholder so we can replace it in the future when those guides are written.
Confirming if the process was exited for proactive invocation of `process.exit`.
0a0df4f
to
a3b9520
Compare
Confirming if the process was exited for proactive invocation of
process.exit
.The option is available after nodejs/node#30516 has been landed.