-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warn for 50 < title <= 72 #18
Conversation
The PR has landed. CI is not working because this repo has been moved, but this does not pass the tests locally. Can you fix the lint errors and the test? Thanks! @refack |
BTW: Just checked travis, it is working, it just can't update it's status: https://travis-ci.org/nodejs/core-validate-commit/builds/300959458 Tests are WIP |
@refack Yes, I think I need to add this repo to nodejs/github-bot#156 |
Ping @evanlucas this looks ready to land, I've bumped into the 72 chars limit quite a bit lately when landing commits |
@evanlucas Thanks, I've taken the liberty to merge this. Can you release a new version? |
Published in v3.5.0. Thanks! Also, @joyeecheung do you need publish access to this package? If so, I can add you :] |
@evanlucas Yeah I would be happy to do the releases! Thanks! |
@joyeecheung what is your npm username? |
@evanlucas Same as my github handle: https://www.npmjs.com/~joyeecheung |
Done. Thanks! |
if nodejs/node#16523 lands