Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn for 50 < title <= 72 #18

Merged
merged 5 commits into from
Jan 15, 2018
Merged

warn for 50 < title <= 72 #18

merged 5 commits into from
Jan 15, 2018

Conversation

refack
Copy link
Contributor

@refack refack commented Oct 26, 2017

@joyeecheung
Copy link
Member

joyeecheung commented Nov 12, 2017

The PR has landed. CI is not working because this repo has been moved, but this does not pass the tests locally. Can you fix the lint errors and the test? Thanks! @refack

@refack
Copy link
Contributor Author

refack commented Nov 12, 2017

BTW: Just checked travis, it is working, it just can't update it's status: https://travis-ci.org/nodejs/core-validate-commit/builds/300959458

Tests are WIP

@joyeecheung
Copy link
Member

@refack Yes, I think I need to add this repo to nodejs/github-bot#156

@refack
Copy link
Contributor Author

refack commented Nov 13, 2017

@joyeecheung
Copy link
Member

Ping @evanlucas this looks ready to land, I've bumped into the 72 chars limit quite a bit lately when landing commits

evanlucas

This comment was marked as off-topic.

@joyeecheung
Copy link
Member

@evanlucas Thanks, I've taken the liberty to merge this. Can you release a new version?

@evanlucas
Copy link
Contributor

Published in v3.5.0. Thanks! Also, @joyeecheung do you need publish access to this package? If so, I can add you :]

@joyeecheung
Copy link
Member

@evanlucas Yeah I would be happy to do the releases! Thanks!

@evanlucas
Copy link
Contributor

@joyeecheung what is your npm username?

@joyeecheung
Copy link
Member

@evanlucas Same as my github handle: https://www.npmjs.com/~joyeecheung

@evanlucas
Copy link
Contributor

Done. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants