-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial macOS ansible scripts #971
Conversation
I don't think
About this PR, shouldn't the two files under This shouldn't land with the current inventory. A partial one is ok, or even no inventory entries. Also, Gibson raised a valid point about the duplicated |
I was thinking that maybe |
That would be quite nice! The |
Agreed it would be nice if there was a script that could be used to start/stop which calls the version for the specific platform. Maybe "agent-control" with start and stop options ? |
cc1e899
to
af48068
Compare
Can we land this, and iterate later? On just land the inventory? |
BTW the libuv jobs need |
I'm all for landing minus the inventory and then updating once we have additional changes (like adding in support for ccache) |
SGTM, but it'd be good to add some TODOs to the source code (like for adding ccache) so we've noted the gaps. |
It was just waiting on a fix up for cache. But I'm +1 for landing and then fixing that |
So we are able to easily install ccache. My only remaining issue is adding ccache to the path of the jenkins node. I added the path to ccache in |
@gdams is |
@gibfahn I'm not 100% sure. I'll do some investigation. |
I needed the macstadium hosts in my ssh config and @Trott couldn't figure it out to go fix some broken hosts so I've pulled out the inventory.yml and plugin fixes here and pushed them to master as 0495bc2. It'd be good if we could get this merged soon, it can be iterated on once merged if it's not fully working yet. |
I'm +1 on merging and then updating if we need to. @gdams can you rebase and then we'll do that? |
Yep, we an just leave TODOs where things aren't working yet (or need manual setup). |
updated PTAL |
@mhdawson I think those merge issues are now cleared up |
Ok, will try to land by the end of week unless there are objections, comments from other @nodejs/build team members. |
@gdams can you squash your commits. git am is failing with conflicts even with -3. I suspect that if you squash that will get rid of the issue. |
b8e5858
to
dbbea51
Compare
@mhdawson rebased and squashed |
PR-URL: #971 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: João Reis <[email protected]>
Landed as eb68f59 |
Okay so here are my initial ansible scripts for macOS. Obviously the inventory isn't complete yet but I will work with @mhdawson to get that side ready. I have confirmed that this works with a blank machine from macstadium (also ran a test build to confirm all tools were in place).
Things to note:
this requires
NOPASSWD
to be added to the sudoers file to enable elevationPossible things to add?
do we want to disable the firewall on the test machines to prevent tonnes of popups?