Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Windows Inventory #2860

Merged

Conversation

joaocgreis
Copy link
Member

We changed the Azure subscription used for the CI machines, this PR updates the Ansible inventory. The new Windows ARM machines hosted by NearForm are also included (ref #2540).

Two important changes were made:

  • Removed VCBT2015 (not VS2015) machines and configurations, as the install package no longer works. Already removed from Jenkins as well. I believe testing with VS2015 provides enough coverage for a version so old.
  • Only server images are supported on the new subscription, so I was not able to create Windows 10 machines. For now, I replaced it with Windows Server 2022. The server names don't yet reflect this everywhere, at least the VersonSelectorScript needs to be updated before the server names can change.

cc @nodejs/libuv, I swapped the VCBT2015 configuration to VS2019.

Update IPs after changing the Azure subscription and add
NearForm Windows ARM machines.
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaced it with Windows Server 2022

In your assessment is this a good enough replacement? How much of a gap are we leaving open here for possible problems on 10 that don't show up on 2022?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joaocgreis
Copy link
Member Author

@rvagg Windows Server 2022 is between Windows 10 and 11 (but closer to 10). It's always possible to have issues specific to a single version/build/combination, but I think in this case it's not very likely to happen. We still test on 2012 and 2016.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants