Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update normal Jenkins security matrix #2344

Merged
merged 2 commits into from
Jun 16, 2020

Conversation

richardlau
Copy link
Member

Add the "Job Read" permission for Authenticated users to allow them
to see the results of CI jobs.

Refs: nodejs/node#33702 (comment)
Refs: #2336 (comment)

Add the "Job Read" permission for Authenticated users to allow them
to see the results of CI jobs.
@richardlau
Copy link
Member Author

Holding off merging this for a bit to await the outcome of #2343 (comment)

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau
Copy link
Member Author

I've updated the image again to account for #2343.
@AshCripps @mhdawson Please could I have another recheck?

@richardlau richardlau linked an issue Jun 16, 2020 that may be closed by this pull request
@richardlau richardlau merged commit 7887eb3 into nodejs:master Jun 16, 2020
@richardlau richardlau deleted the update-sec-matrix branch June 16, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bring back ci.nodejs.org autologin
3 participants