Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: jenkins: add selection for building on osx1011 #1409

Merged
merged 4 commits into from
Jul 25, 2018

Conversation

mhdawson
Copy link
Member

No description provided.

@mhdawson
Copy link
Member Author

Selector script does not seem to be getting the node version properly on the test machines, even though it seemed ok on the release machines: https://ci.nodejs.org/view/All/job/node-test-commit-osx-mdawson/1/console

targos

This comment was marked as off-topic.

maclover7

This comment was marked as off-topic.

refack

This comment was marked as off-topic.

@refack refack merged commit dc56ae8 into nodejs:master Jul 25, 2018
@refack
Copy link
Contributor

refack commented Jul 25, 2018

For posterity: when enabling VersionSelectorScript.groovy also need to enable the NodeVersionExtension SCM plugin with exportNodejsVersion checked.

@mhdawson
Copy link
Member Author

Hmm, from what I can tell landing this may have caused us to no longer have releases on osx.

I was half way through testing and had not yet added the 1011 release machine to the infra. Once this landed that would mean we would not build at all on osx for 11 and greater.

I'll add the machine in now.

@refack
Copy link
Contributor

refack commented Jul 30, 2018

Hmm, from what I can tell landing this may have caused us to no longer have releases on osx.

Since this has gte(11) it should not have affected v10 releases.
I landed it to unbreak nodejs/node#21079 and opened #1415 to track the release issues.

@mhdawson
Copy link
Member Author

@refack the problem was that in the release ci the nightlies are built and are version 11. Since the script landed and excluded building 11 on the existing release machines (which were only osx 1010) we've had no nightly builds.

I'm just in the process of adding the 1011 release machine, which I was going to do once I'd finished testing things out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants