Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS pkg release build failures #2850

Closed
targos opened this issue Jan 18, 2022 · 4 comments
Closed

macOS pkg release build failures #2850

targos opened this issue Jan 18, 2022 · 4 comments
Labels
ci-release incident

Comments

@targos
Copy link
Member

targos commented Jan 18, 2022

The last four nightly builds failed. See https://ci-release.nodejs.org/job/iojs+release/8214/nodes=osx11-release-pkg/console
@targos
Copy link
Member Author

targos commented Jan 18, 2022

@nodejs/jenkins-release-admins

@targos targos mentioned this issue Jan 18, 2022
Merged
@rvagg
Copy link
Member

rvagg commented Jan 18, 2022

https://github.com/nodejs/node/blob/6beee312a47165f8dd65fe802b6280310e6caede/Makefile#L833

that line will need fixing, npm's package.json has a new "templateOSS" section with a "version": "2.4.3" in it, so NPMVERSION is coming out as:

8.3.1
    "version": "2.4.3"

rather than just 8.3.1 as it would previously have done.

hence:

07:10:54 pkgbuild --version v8.3.1     "version": "2.4.3" \
07:10:54 		--identifier org.nodejs.npm.pkg \
07:10:54 		--root out/macos/dist/npm \
07:10:54 		--scripts ./tools/macos-installer/pkgbuild/npm/scripts \
07:10:54 			out/macos/pkgs/npm-v8.3.1     "version": "2.4.3".pkg

in the build logs

@targos targos mentioned this issue Jan 18, 2022
Closed
targos added a commit to targos/node that referenced this issue Jan 18, 2022
@targos
build: fix npm version detection
a8f0fee 
Npm's package.json now contains two fields named "version".
Grep for the top-level one.

Fixes: nodejs/build#2850
@targos
Copy link
Member Author

targos commented Jan 18, 2022

Proposed fix: nodejs/node#41575

targos added a commit to nodejs/node that referenced this issue Jan 18, 2022
@targos
build: fix npm version detection
4958c80 
Npm's package.json now contains two fields named "version".
Grep for the top-level one.

Fixes: nodejs/build#2850

PR-URL: #41575
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos
Copy link
Member Author

targos commented Jan 18, 2022

Thanks for investigating @rvagg !

thedull pushed a commit to thedull/node that referenced this issue Jan 18, 2022
@targos @thedull
build: fix npm version detection
f365414 
Npm's package.json now contains two fields named "version".
Grep for the top-level one.

Fixes: nodejs/build#2850

PR-URL: nodejs#41575
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this issue Jan 31, 2022
@targos @Linkgoron
build: fix npm version detection
aa07097 
Npm's package.json now contains two fields named "version".
Grep for the top-level one.

Fixes: nodejs/build#2850

PR-URL: nodejs#41575
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit to nodejs/node that referenced this issue Feb 1, 2022
@targos @danielleadams
build: fix npm version detection
5c1dc5f 
Npm's package.json now contains two fields named "version".
Grep for the top-level one.

Fixes: nodejs/build#2850

PR-URL: #41575
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci-release incident
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: fix npm version detection targos/node
2 participants
@rvagg @targos