-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nominating @RichardLau for Releasers team #585
Comments
+1!!! |
+1 |
+1! |
+1 |
@richardlau, it is worth running through the 'Who Can Make A Release?' section. Please let me know if there is any access that requires someone with admin permissions to grant. I'm also assuming you do not yet have access to https://github.com/nodejs-private/node-private for security releases. I do not know the process of adding releasers to that organisation. Can anyone from @nodejs/releasers confirm it is just a case of inviting Richard to the GitHub organisation and relevant teams? |
@BethGriggs According to the process in https://github.com/nodejs/Release/blob/master/GOVERNANCE.md being added to the team happens after preparing a release? Or maybe the ordering doesn't matter if there are no objections (in which case we should update the docs)? I can confirm I currently do not have access to https://github.com/nodejs-private/node-private. FWIW I've been trying to add my gpg key to the public keyservers (via the submission link in https://github.com/nodejs/node/blob/master/doc/guides/releases.md#3-a-publicly-listed-gpg-key) but so far haven't been able to retrieve it via the command. |
Converted #588 back to a draft and hold off with accesses until the first release is prepared. I think the wording can be improved, as the following implied to me that the new releaser would kick off the builds (which you need to be in the release team for). Although, I think you have ci-release access via the Build WG anyway.
It would probably also be worth refactoring releases.md or adding a reference back to the Release governance documentation as they seem to overlap.
There are probably enough commits and backports to warrant preparing a v10.x release. |
https://github.com/nodejs/docker-node/blob/master/keys/node.keys probably also needs to be updated, but I didn't see that in the release.md. |
It’s listed in https://github.com/nodejs/Release/blob/master/GOVERNANCE.md#adding-new-releasers. As @BethGriggs said it’s probably worth refactoring release.md. |
Add Richard Lau and his Release key. Signed-off-by: Richard Lau <[email protected]> PR-URL: nodejs#34397 Refs: nodejs/Release#585 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Add Richard Lau and his Release key. Signed-off-by: Richard Lau <[email protected]> PR-URL: #34397 Refs: nodejs/Release#585 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Add Richard Lau and his Release key. Signed-off-by: Richard Lau <[email protected]> PR-URL: #34397 Refs: nodejs/Release#585 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Add Richard Lau and his Release key. Signed-off-by: Richard Lau <[email protected]> PR-URL: #34397 Refs: nodejs/Release#585 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Add Richard Lau and his Release key. Signed-off-by: Richard Lau <[email protected]> PR-URL: #34397 Refs: nodejs/Release#585 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Add Richard Lau and his Release key. Signed-off-by: Richard Lau <[email protected]> PR-URL: #34397 Refs: nodejs/Release#585 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Socialised via email to the @nodejs/tsc as per:
The text was updated successfully, but these errors were encountered: