Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support node10 #423

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rzr
Copy link

@rzr rzr commented Dec 20, 2018

rzr added 2 commits December 20, 2018 17:20
node-10 support to come later

Forwarded: noble#422
Origin: CrossStream@6e0d5d6
Change-Id: Ie8c3b328fd8736a80a3b91fb23702cc4152943b4
Signed-off-by: Philippe Coval <[email protected]>
Origin: noble#423
Relate-to: abandonware/noble#2
Cc: @petersaints
Change-Id: I72d4f9c553a2cd1387d82884d330a4aa35c28703
Signed-off-by: Philippe Coval <[email protected]>
@rzr rzr force-pushed the sandbox/rzr/abandonware/review/master branch from 49f62f9 to e0a8953 Compare December 20, 2018 16:25
@petersaints
Copy link

@rzr
I still have to test @abadonaware/noble and this bleno pull request on the project where I'm using them. So far I have been using https://github.com/jrobeson/node-bluetooth-hci-socket/#fix-builds-for-node-10 as a replacement for node-bluetooth-hci-socket, together with noble and bleno packages on the npm registry. I'll try it out soon and I'll give some feedback if everything worked as intended.

@zhangyanrui
Copy link

same problem

@petersaints
Copy link

petersaints commented Mar 22, 2019 via email

@rzr
Copy link
Author

rzr commented Apr 18, 2019

Please review,
if none, I am considering to release a version of:
https://github.com/abandonware/bleno/

on npm too, then track:
https://www.npmjs.com/~rzr

Merge this small changes with the "/sandbox/rzr/abandonware/review/master" in order to release it as @abadonware/bleno on npm
@rzr
Copy link
Author

rzr commented Sep 2, 2019

This change is released in:
https://www.npmjs.com/package/@abandonware/bleno/v/0.5.1-0

@rzr
Copy link
Author

rzr commented Feb 20, 2021

Please confirm this issue is resolved with @abandonware version

Relate-to: abandonware#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants