Make preadv take immutable slice of IoVecs #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
requested changes
Jul 2, 2018
|
Should be fine now ♻️ |
|
Not quite. There's a typo in the new changelog entry. |
|
👍 |
asomers
approved these changes
Jul 3, 2018
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 3, 2018
914: Make preadv take immutable slice of IoVecs r=asomers a=farnoy fixes #913 I filled in the CHANGELOG, but I see that it usually links to PRs and not issues, do you want me to change it or remove and leave for you to describe? This change seems to be strictly backwards-compatible, I didn't have to change the test for it to work. Co-authored-by: Jakub Okoński <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #913
I filled in the CHANGELOG, but I see that it usually links to PRs and not issues, do you want me to change it or remove and leave for you to describe?
This change seems to be strictly backwards-compatible, I didn't have to change the test for it to work.