Match syntax of libc_bitflags! with bitflags! #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Susurrus
force-pushed
the
bitflags
branch
9 times, most recently
from
8845dc2 to
cd21efc
Compare
|
@asomers Want to give this a quick glance-over for me? It should be pretty straight-forward. |
asomers
requested changes
Aug 11, 2017
| bits: [0; FD_SETSIZE as usize / BITS] | ||
| } | ||
| let mut fdset = unsafe { mem::uninitialized() }; | ||
| unsafe { libc::FD_ZERO(&mut fdset) }; |
There was a problem hiding this comment.
This shouldn't require unsafe. FD_ZERO is implemented in pure Rust. Same for FD_CLR, FD_SET, and FD_ISSET
There was a problem hiding this comment.
Same thing as WIFCONTINUED, this is how they're defined in libc:
pub unsafe extern "C" fn FD_SET(fd: c_int, set: *mut fd_set);
Susurrus
force-pushed
the
bitflags
branch
3 times, most recently
from
0276742 to
4588d4c
Compare
|
@asomers Want to give this another look over now? Should be RFM. |
|
LGTM. But can you squash the last commit? |
|
@asomers Squash that last commit into which other commit? I left it separate because it didn't seem appropriate to merge it with any other changes in this patchset. |
|
Sorry, I thought that the extra bors r+ |
Timed out (retrying...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update a couple of constant declarations while we're at it.