Let freebsd and openbsd access 'poll'

[berkowski]

Gave freebsd and openbsd access to 'poll'. Don't see a reason why other bsd's shouldn't be added as well. Might make more sense to add exclusive #cfg(not(...) statements around a few OS's instead of long strings of acceptable targets.

[asomers]

Thanks for fixing this. Could you please add a CHANGELOG entry too?

[berkowski]

Sure thing.

[asomers]

This should have the same format as other CHANGELOG messages. Move it into the Changed section, and add a link to the PR

[berkowski]

Yup, my mistake. Sorry for the noise

[berkowski]

Added #711 as this PR doesn't fix the issue for other BSD's

[asomers]

Is there some reason not to add NetBSD and Dragonfly support right now? Do they have poll definitions in libc?

[berkowski]

Only reason at the moment is that I can't easily check locally by using cross to cross-compile with an appropriate bsd toolchain (only x86_64-unknown-freebsd and -netbsd are available as targets in rustup).

I could go through libc, see how things are supported by other BSD's, and try to add support; just can't really test it. Maybe as a separate PR?

[asomers]

You should inspect the code for libc and enable poll on all platforms that have libc support. Better yet would be to inspect the C libraries for each of the BSDs, and add libc poll bindings for any platforms that lack it. Our CI system will catch any mistakes for FreeBSD or NetBSD. OpenBSD and Dragonfly aren't officially supported by Nix, so nobody will be upset with you if you break the build for one of those platforms.

[berkowski]

Fair enough. I'll expand the PR to the other BSD's supported by rust-lang/libc

[Susurrus]

This is already covered in #672 which is close to merging.

[berkowski]

Great. Well I just made a small fuss about nothing then. Sorry for that, didn't catch it in the active issues or PR's