-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the public ptrace_* functions. #692
Merged
Merged
Changes from 2 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
b4f1749
Rename the public ptrace_* functions.
marmistrz 3192df4
Fix tests
marmistrz d5c4d0f
Tidy up imports in test_ptrace.rs
marmistrz 18b2bc1
Get rid of the bulk imports
marmistrz 8928a7d
Remove old workaround
Susurrus 1b9a779
Re-add bad variant of ioctl!
Susurrus a5b01c0
Add a "bad none" variant to the ioctl macro
Susurrus 2fe5c2b
Hide internal macros/types within ioctl
Susurrus 233a678
Remove unnecessary path aliasing
Susurrus 55a7d4b
Revise ioctl module documentation
Susurrus caaffb8
Remove ioc_* functions
Susurrus 82e0139
Use the proper ioctl number type depending on target
Susurrus e4a1851
Remove c_int and c_void from root
Susurrus 88dc19b
Remove unnecessary constants
Susurrus 7b07847
Unify argument names to generated ioctl functions
Susurrus 3cf4cc6
Split ioctl!(write ...) into write_ptr and write_int
Susurrus 571386b
Add 'bad' prefixes for read, write_*, and readwrite ioctls
Susurrus d63c616
Refactor ioctl! for buffers
Susurrus 93b2929
Update changelog
Susurrus 085f47c
Fix thread safety issues in pty and termios tests
asomers 1c9e0ca
fix some tests for Android
ndusart 2a5b86d
Remove workaround for `pub extern crate`
jonas-schievink b6ad298
Remove `homepage` from Cargo.toml
jonas-schievink 845453b
Add tests of actual ioctl usage
Susurrus 903a52f
Add WaitStatus::PtraceSyscall for use with PTRACE_O_TRACESYSGOOD
geofft 2288202
Document WaitStatus and its variants
geofft 907bb98
use std::env::temp_dir() to retrieve the temp directory in test_mkstemp
ndusart a162ea2
Allow doc attributes in ioctl macro
roblabla 745a4ab
Document invariants of fork and fix tests
jonas-schievink 4cefd53
Remove unneeded local
jonas-schievink 536787e
Replace remaining process::exit with libc::_exit
jonas-schievink 283fb1c
Add CHANGELOG entry for PR #661
asomers f3167db
Release 0.9.0
asomers 021e851
Bump version to 0.10.0-pre
asomers 8beaea2
Move Tier 3s to Tier 2
Susurrus 46191fd
Disable tests on s390x
Susurrus a717003
Disable failing tests on mips64
Susurrus ce60aa5
Disable testing because of musl #include issues
Susurrus 1844378
Add a changelog entry
marmistrz 6583fd1
Merge branch 'master' into ptrace-rename
marmistrz 9cf8248
Fix the tests compiling
marmistrz 6ce39a6
Merge branch 'ptrace-rename' of github.com:marmistrz/nix into ptrace-…
marmistrz bf93180
Remove the TODO comments, add unwrap() for ptrace.
marmistrz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
use nix::Error; | ||
use nix::errno::*; | ||
use nix::unistd::*; | ||
use nix::sys::ptrace; | ||
use nix::sys::ptrace::*; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change doesn't seem so useful if you still need to glob import a ton of things. Can we get rid of those here or does that make things really cluttered? |
||
use nix::sys::ptrace::ptrace::*; | ||
|
||
|
@@ -17,21 +18,21 @@ fn test_ptrace() { | |
// Just make sure ptrace_setoptions can be called at all, for now. | ||
#[test] | ||
fn test_ptrace_setoptions() { | ||
let err = ptrace_setoptions(getpid(), PTRACE_O_TRACESYSGOOD).unwrap_err(); | ||
let err = ptrace::setoptions(getpid(), PTRACE_O_TRACESYSGOOD).unwrap_err(); | ||
assert!(err != Error::UnsupportedOperation); | ||
} | ||
|
||
// Just make sure ptrace_getevent can be called at all, for now. | ||
#[test] | ||
fn test_ptrace_getevent() { | ||
let err = ptrace_getevent(getpid()).unwrap_err(); | ||
let err = ptrace::getevent(getpid()).unwrap_err(); | ||
assert!(err != Error::UnsupportedOperation); | ||
} | ||
|
||
// Just make sure ptrace_getsiginfo can be called at all, for now. | ||
#[test] | ||
fn test_ptrace_getsiginfo() { | ||
match ptrace_getsiginfo(getpid()) { | ||
match ptrace::getsiginfo(getpid()) { | ||
Err(Error::UnsupportedOperation) => panic!("ptrace_getsiginfo returns Error::UnsupportedOperation!"), | ||
_ => (), | ||
} | ||
|
@@ -41,7 +42,7 @@ fn test_ptrace_getsiginfo() { | |
#[test] | ||
fn test_ptrace_setsiginfo() { | ||
let siginfo = unsafe { mem::uninitialized() }; | ||
match ptrace_setsiginfo(getpid(), &siginfo) { | ||
match ptrace::setsiginfo(getpid(), &siginfo) { | ||
Err(Error::UnsupportedOperation) => panic!("ptrace_setsiginfo returns Error::UnsupportedOperation!"), | ||
_ => (), | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no module-level documentation for the ptrace module, but it'd be good to add one showing an example usage that demonstrates the namespacing we recomment. We don't need it per-say, but it'd help users use this crate very easily. It'll also help us see where the imports aren't very ergonomic so we can improve them later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add the documentation when I'm done with all the ptrace changes, ok?
Besides, I really think about splitting up #666 into a couple smaller PRs because I'm starting to lose control of the tests.