-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed signature for openat function #2139
Changed signature for openat function #2139
Conversation
Signed-off-by: carlosb1 <[email protected]>
Signed-off-by: carlosb1 <[email protected]>
PR LGTM, except for the missing change log. You need to add a change log to
And, it would be great if you squash your commits into a single one :) Update: commits don't need to be squashed as this will be done automatically |
Signed-off-by: carlosb1 <[email protected]>
Signed-off-by: carlosb1 <[email protected]>
I updated the changelog as you commented. I expect now it is correct |
I can not merge it, I don't have write access, very happy to contribute in anything else. |
Thanks for doing this! :) |
Fixing #1850 , Changed signature to use an Optional
rawfd