feat: I/O safety for 'sys/sendfile' #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveLauC
force-pushed
the
io-safety-sys/sendfile
branch
from
58cd780 to
31c4dec
Compare
SteveLauC
commented
Dec 8, 2022
| pub fn sendfile( | ||
| out_fd: RawFd, | ||
| in_fd: RawFd, | ||
| pub fn sendfile<F1: AsFd, F2: AsFd>( |
There was a problem hiding this comment.
Two generic types are needed as in_fd and out_fd may be different types when used.
SteveLauC
commented
Dec 8, 2022
SteveLauC
force-pushed
the
io-safety-sys/sendfile
branch
from
31c4dec to
d53db5c
Compare
asomers
reviewed
Dec 8, 2022
SteveLauC
force-pushed
the
io-safety-sys/sendfile
branch
from
d53db5c to
ab5c032
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
sys/sendfile.