Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getrusage wrapper #1747

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Add getrusage wrapper #1747

merged 1 commit into from
Jun 21, 2022

Conversation

kov
Copy link

@kov kov commented Jun 19, 2022

Includes an enum to specify what to get resource usage for, and a new
struct that provides a more readable view into libc::rusage, including
using TimeVal for user and system CPU time.

Signed-off-by: Gustavo Noronha Silva [email protected]

@kov kov force-pushed the add-getrusage branch 2 times, most recently from 88defff to 83927a4 Compare June 19, 2022 01:28
rtzoeller
rtzoeller reviewed Jun 20, 2022
View reviewed changes
Copy link
Collaborator

@rtzoeller rtzoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you add a note to the changelog linking back to this PR (squashed into the current commit)?

@kov
Copy link
Author

kov commented Jun 20, 2022

Thanks! Can you add a note to the changelog linking back to this PR (squashed into the current commit)?

Is this how it is usually done? I found it in the history but it seemed to be always done by a bot or something?

    1747: add getrusage wrapper
    
    Includes an enum to specify what to get resource usage for, and a new
    struct that provides a more readable view into libc::rusage, including
    using TimeVal for user and system CPU time.

@kov kov force-pushed the add-getrusage branch from 83927a4 to 1908f82 Compare June 20, 2022 18:22
@rtzoeller
Copy link
Collaborator

We use a tool called bors to ensure PRs merged at the same time don't break the build. I believe this was what you were referring to.

The CHANGELOG.md updates are made manually though; can you modify CHANGELOG.md, similar to this PR? Ideally the changelog is modified in the same commit as the existing one, because bors won't squash the commit history when merging.

@kov
Copy link
Author

kov commented Jun 21, 2022

Oh, I thought you meant the commit message, didn't notice there was a changelog. On it!

@kov kov force-pushed the add-getrusage branch from 1908f82 to 2d1b323 Compare June 21, 2022 01:09
@kov
Add getrusage wrapper
9313a18 
Includes an enum to specify what to get resource usage for, and a new
struct that provides a more readable view into libc::rusage, including
using TimeVal for user and system CPU time.
@kov kov force-pushed the add-getrusage branch from 2d1b323 to 9313a18 Compare June 21, 2022 01:10
rtzoeller
rtzoeller approved these changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@rtzoeller rtzoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 21, 2022

Build succeeded:

@bors bors bot merged commit 2c7bb2a into nix-rust:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtzoeller rtzoeller rtzoeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kov @rtzoeller