Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the SO_TXTIME sockopt and SCM_TXTIME control message #1564

Merged
merged 1 commit into from
Dec 30, 2021
Merged

Add support for the SO_TXTIME sockopt and SCM_TXTIME control message #1564

merged 1 commit into from
Dec 30, 2021

Conversation

ghedo
Copy link
Contributor

@ghedo ghedo commented Oct 16, 2021

No description provided.

asomers
asomers requested changes Oct 16, 2021
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add a test for this sockopt?

src/sys/socket/sockopt.rs Outdated Show resolved Hide resolved
@asomers asomers added this to the 0.24.0 milestone Oct 16, 2021
@ghedo
Copy link
Contributor Author

ghedo commented Oct 18, 2021

Added a description for the socket option and a test. Note that the test requires at least Linux 5.8 to work without root or CAP_NET_ADMIN (see this commit torvalds/linux@790709f249728). However, neither of those things seem to be available in CI.

PTAL @asomers.

@ghedo ghedo requested a review from asomers October 18, 2021 12:57
@asomers
Copy link
Member

asomers commented Dec 21, 2021

@ghedo needs a rebase

@ghedo
Copy link
Contributor Author

ghedo commented Dec 29, 2021

@asomers done.

@asomers
Copy link
Member

asomers commented Dec 30, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 30, 2021

Build succeeded:

@bors bors bot merged commit b9eb197 into nix-rust:master Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ghedo @asomers