Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally implement TryFrom in libc_enum! #1484

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Optionally implement TryFrom in libc_enum! #1484

merged 1 commit into from
Aug 11, 2021

Conversation

asomers
Copy link
Member

@asomers asomers commented Aug 10, 2021

This saves code in several separate places that need to do this
separately. At the same time, remove a few uses of mem::transmute that
were implementing TryFrom or similar functionality.

Issue #373

@asomers asomers requested a review from Susurrus August 10, 2021 00:10
@asomers asomers force-pushed the libc_enum_try_from branch from ec41684 to 0c6d576 Compare August 10, 2021 00:11
@asomers
Optionally implement TryFrom in libc_enum!
9df5abf 
This saves code in several separate places that need to do this
separately.  At the same time, remove a few uses of mem::transmute that
were implementing TryFrom or similar functionality.

Issue nix-rust#373
@asomers asomers force-pushed the libc_enum_try_from branch from 0c6d576 to 9df5abf Compare August 10, 2021 00:51
@Susurrus
Copy link
Contributor

Sorry @asomers, but I'm not going to be able to review this. I've been out of the coding game for quite a while now, even giving up maintenance of serialport-rs in favor of other life pursuits. Hopefully some of the other maintainers can assist. I'm going to remove myself from the nix-maintainers team as well as I think that's appropriate at this stage. I have stayed on as I thought I might return, but at this point I don't think that's going to happen.

@Susurrus Susurrus removed their request for review August 10, 2021 04:52
@asomers
Copy link
Member Author

asomers commented Aug 10, 2021

Out of the coding game entirely, as in even professionally?

asomers
asomers commented Aug 10, 2021
View reviewed changes
Copy link
Member Author

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 11, 2021

Build succeeded:

@bors bors bot merged commit a7e86b2 into nix-rust:master Aug 11, 2021
@Susurrus
Copy link
Contributor

I write very little code at work since about 4y now, only coding was for personal stuff. And I've realized I want to prioritize some other things. Appreciate working with you on this project and it was a great experience helping to build and maintain nix!

@asomers asomers deleted the libc_enum_try_from branch September 29, 2021 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asomers @Susurrus