-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clippy cleanup #1107
Clippy cleanup #1107
Conversation
It was leftover from internal churn during PR nix-rust#1020.
bors r+ |
1107: Clippy cleanup r=asomers a=asomers This is preparation for several changes relating to raising the MSRV, most importantly eliminating `mem::uninitialized`. Co-authored-by: Alan Somers <[email protected]>
Build failed |
The build failure was caused by four failures to download japaric/cross. bors retry |
1107: Clippy cleanup r=asomers a=asomers This is preparation for several changes relating to raising the MSRV, most importantly eliminating `mem::uninitialized`. Co-authored-by: Alan Somers <[email protected]>
Build succeeded
|
- `Ipv4Addr::octets`, `Ipv4Addr::to_std`, `Error::as_errno`, | ||
`ForkResult::is_child`, `ForkResult::is_parent`, `Gid::as_raw`, | ||
`Uid::is_root`, `Uid::as_raw`, `Pid::as_raw`, and `PollFd::revents` now take | ||
`self` by value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the motivation for taking self
by value? Doesn't that either consume the original value or require Copy? This change was part of the "Clippy cleanup" commit, which doesn't provide any other context.
This is preparation for several changes relating to raising the MSRV, most importantly eliminating
mem::uninitialized
.