Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy cleanup #1107

Merged
merged 6 commits into from
Aug 30, 2019
Merged

Clippy cleanup #1107

merged 6 commits into from
Aug 30, 2019

Conversation

asomers
Copy link
Member

@asomers asomers commented Aug 19, 2019

This is preparation for several changes relating to raising the MSRV, most importantly eliminating mem::uninitialized.

@asomers asomers requested a review from Susurrus August 19, 2019 23:29
@asomers asomers added this to the 0.16.0 milestone Aug 19, 2019
@asomers
Copy link
Member Author

asomers commented Aug 30, 2019

bors r+

bors bot added a commit that referenced this pull request Aug 30, 2019
Merge #1107

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1107: Clippy cleanup r=asomers a=asomers

This is preparation for several changes relating to raising the MSRV, most importantly eliminating `mem::uninitialized`.

Co-authored-by: Alan Somers <[email protected]>
@bors
Copy link
Contributor

bors bot commented Aug 30, 2019

Build failed

@asomers
Copy link
Member Author

asomers commented Aug 30, 2019

The build failure was caused by four failures to download japaric/cross.

bors retry

bors bot added a commit that referenced this pull request Aug 30, 2019
Merge #1107

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1107: Clippy cleanup r=asomers a=asomers

This is preparation for several changes relating to raising the MSRV, most importantly eliminating `mem::uninitialized`.

Co-authored-by: Alan Somers <[email protected]>
@bors
Copy link
Contributor

bors bot commented Aug 30, 2019

Build succeeded

@bors bors bot merged commit 1c267ca into nix-rust:master Aug 30, 2019
@asomers asomers deleted the clippy branch August 30, 2019 17:43
- `Ipv4Addr::octets`, `Ipv4Addr::to_std`, `Error::as_errno`,
`ForkResult::is_child`, `ForkResult::is_parent`, `Gid::as_raw`,
`Uid::is_root`, `Uid::as_raw`, `Pid::as_raw`, and `PollFd::revents` now take
`self` by value.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the motivation for taking self by value? Doesn't that either consume the original value or require Copy? This change was part of the "Clippy cleanup" commit, which doesn't provide any other context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants