Skip to content

Commit

Permalink
Add overrides removing LICENSE files
Browse files Browse the repository at this point in the history 
They lead to collisions.

Probably there should be some cleanup for these kind of files? cc @FRidh
  • Loading branch information
@adisbladis
adisbladis committed Jan 12, 2020
1 parent 2f59f1d commit bf56efe
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions overrides.nix
View file
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,14 @@ in
}
);

pytest-datadir = super.pytest-datadir.overrideAttrs (
old: {
postInstall = ''
rm -f $out/LICENSE
'';
}
);

python-prctl = super.python-prctl.overrideAttrs (
old: {
buildInputs = old.buildInputs ++ [
Expand Down Expand Up @@ -345,6 +353,14 @@ in
}
);

vose-alias-method = super.pytest-datadir.overrideAttrs (
old: {
postInstall = ''
rm -f $out/LICENSE
'';
}
);

# Stop infinite recursion by using bootstrapped pkg from nixpkgs
wheel = (
pkgs.python3.pkgs.override {
Expand Down

3 comments on commit bf56efe

@robertodr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@FRidh
Copy link
Contributor

@FRidh FRidh commented on bf56efe Jan 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an (upstream) open issue on data_files that are installed in the wrong place. Been open for years.

@coderfromhere
Copy link
Contributor

@coderfromhere coderfromhere commented on bf56efe Jan 23, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention it here NixOS/nixpkgs#23438 to keep as a reminder.
The issue is quite serious as date_files may include blobs that the package depends on at runtime and at the moment there's no clear indication that the successfully evaluated nix-shell may result in incorrect data placement.

Please sign in to comment.