Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/types: maybeRaw should propagate elemType's sub-options #2341

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MattSturgeon
Copy link
Member

This is technically redundant, because we patch either to be recursive. But I think it is best if maybeRaw does this explicitly, without relying on that behaviour.

@MattSturgeon
Copy link
Member Author

error: A definition for option `plugins.cmp.settings.sources' is not of type `list of (attribute set of anything)'. Definition values:
- In `/nix/store/a9v1l0scrw2nmsp7k40kywijf78mns6s-test-sources/plugins/cmp/default.nix':
    {
      __raw = ''
        cmp.config.sources({
          {
            {name = "path"},
    ...

I have no idea how this change could trigger that though...

inherit (elemType)
getSubModules
getSubOptions
substSubModules
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a proper substSubModules is a little more complex than just re-using the elem-type's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant