Skip to content

Commit

Permalink
fix: remove console.log (#1094)
Browse files Browse the repository at this point in the history
  • Loading branch information
ninoseki authored Jun 28, 2024
1 parent 97ca078 commit 6d74efb
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 17 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/node.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,4 @@ jobs:
- name: Run type-check
run: npm run type-check
- name: Run ESLint
run: npx eslint
run: NODE_ENV=production npx eslint
22 changes: 11 additions & 11 deletions frontend/.eslintrc.cjs
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
/* eslint-env node */
require('@rushstack/eslint-patch/modern-module-resolution')
require("@rushstack/eslint-patch/modern-module-resolution")

module.exports = {
root: true,
extends: [
'plugin:vue/vue3-essential',
'eslint:recommended',
'@vue/eslint-config-typescript',
'@vue/eslint-config-prettier/skip-formatting'
"plugin:vue/vue3-essential",
"eslint:recommended",
"@vue/eslint-config-typescript",
"@vue/eslint-config-prettier/skip-formatting"
],
plugins: ['simple-import-sort'],
plugins: ["simple-import-sort"],
rules: {
'no-console': process.env.NODE_ENV === 'production' ? 'warn' : 'off',
'no-debugger': process.env.NODE_ENV === 'production' ? 'warn' : 'off',
'simple-import-sort/imports': 'error',
'simple-import-sort/exports': 'error'
"no-console": process.env.NODE_ENV === "production" ? "error" : "warn",
"no-debugger": process.env.NODE_ENV === "production" ? "error" : "warn",
"simple-import-sort/imports": "error",
"simple-import-sort/exports": "error"
},
parserOptions: {
ecmaVersion: 'latest'
ecmaVersion: "latest"
}
}
2 changes: 0 additions & 2 deletions frontend/src/components/artifact/ActionButtons.vue
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,7 @@ const deleteArtifact = async () => {
if (confirmed) {
try {
console.log("baz?")
await deleteArtifactTask.perform(props.artifact.id)
console.log("baz")
emits("delete")
} catch (err) {
if (axios.isAxiosError(err)) {
Expand Down
1 change: 0 additions & 1 deletion frontend/src/components/artifact/ArtifactItem.vue
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ const onDisposeError = () => {
const onDelete = () => {
emits("delete")
console.log("foo")
}
const onSetMessage = (newMessage: QueueMessageType) => {
Expand Down
1 change: 0 additions & 1 deletion frontend/src/components/artifact/ArtifactsItem.vue
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ const onUpdatePage = (page: number) => {
}
const onDelete = () => {
console.log("bar")
emits("refresh")
}
</script>
Expand Down
1 change: 0 additions & 1 deletion frontend/src/components/artifact/ArtifactsWrapper.vue
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ const getArtifacts = async () => {
}
const onUpdatePage = (newPage: number) => {
console.log(newPage)
page.value = newPage.toString()
}
Expand Down

0 comments on commit 6d74efb

Please sign in to comment.