Merge pull request #997 from ninoseki/stop-retyring-on-401

refactor: stop retrying on 401
ninoseki · Jan 8, 2024 · 19068fa · 19068fa
2 parents 8af00a9 + 5d092f1
commit 19068fa
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/mihari/concerns/retriable.rb b/lib/mihari/concerns/retriable.rb
@@ -21,7 +21,7 @@ module Retriable
 
         case error
         when StatusError
-          error.status_code != 404
+          ![401, 404].include?(error.status_code)
         else
           false
         end

diff --git a/spec/concerns/retriable_spec.rb b/spec/concerns/retriable_spec.rb
@@ -40,6 +40,13 @@ def http
       end
     end
 
+    context "with 401" do
+      it do
+        expect { subject.retriable_get("#{server.base_url}/status/401") }.to raise_error(Mihari::StatusError)
+        expect(subject.count).to eq(1)
+      end
+    end
+
     context "with non-404" do
       it do
         expect { subject.retriable_get("#{server.base_url}/status/500") }.to raise_error(Mihari::StatusError)