Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create enum for z-index values #1722

Merged
merged 9 commits into from
Jan 5, 2024
Merged

Create enum for z-index values #1722

merged 9 commits into from
Jan 5, 2024

Conversation

m-akinc
Copy link
Contributor

@m-akinc m-akinc commented Jan 2, 2024

Pull Request

🀨 Rationale

Fixes #539

πŸ‘©β€πŸ’» Implementation

  • Created a new enum in utilities with a few preset z-index values.
  • Updated stylesheets for anchored-region, dropdown, and table to use enum values rather than hardcoded values.

πŸ§ͺ Testing

None

βœ… Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@m-akinc m-akinc requested a review from atmgrifter00 January 2, 2024 21:57
@m-akinc
Copy link
Contributor Author

m-akinc commented Jan 2, 2024

@atmgrifter00 could you please buddy this?

@m-akinc m-akinc requested a review from atmgrifter00 January 3, 2024 17:10
@m-akinc m-akinc marked this pull request as ready for review January 3, 2024 21:38
@m-akinc m-akinc requested a review from jattasNI January 3, 2024 22:42
@m-akinc m-akinc enabled auto-merge (squash) January 4, 2024 23:26
@m-akinc m-akinc merged commit fc2fd87 into main Jan 5, 2024
10 checks passed
@m-akinc m-akinc deleted the users/makinc/z-index-enum branch January 5, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create global enum for managing z-indexes
4 participants