Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atomic-browser: init at 0.37.0 #170

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

albertchae
Copy link
Contributor

@albertchae albertchae commented Apr 11, 2024

Part of #15

Co-authored-by: Anish Lakhwara [email protected]

@albertchae albertchae force-pushed the moss/atomic-browser-with-fetch-pnpm-deps branch from 6838db1 to 5125a83 Compare April 11, 2024 06:20
@fricklerhandwerk
Copy link
Collaborator

Discussed with @albertchae and @Chickensoupwithrice

Let's try to move forward with NixOS/nixpkgs#290715 and leverage upstream if possible.

@ngi-nix ngi-nix deleted a comment from github-actions bot Apr 12, 2024
@ngi-nix ngi-nix deleted a comment from github-actions bot Apr 12, 2024
@ngi-nix ngi-nix deleted a comment from github-actions bot Apr 12, 2024
@lorenzleutgeb lorenzleutgeb changed the title [WIP] moss/atomic browser with fetch pnpm deps moss/atomic browser with fetch pnpm deps Jun 4, 2024
@wegank
Copy link
Member

wegank commented Jun 6, 2024

NixOS/nixpkgs#290715 has been upstreamed.

@albertchae albertchae force-pushed the moss/atomic-browser-with-fetch-pnpm-deps branch from 5125a83 to 84ef22b Compare June 10, 2024 13:43
- Use pnpm_8.fetchDeps to fetch dependencies and build
- Modeled after build steps in https://github.com/atomicdata-dev/atomic-server/blob/develop/browser/Earthfile

Co-authored-by: Anish Lakhwara <[email protected]>
@albertchae albertchae force-pushed the moss/atomic-browser-with-fetch-pnpm-deps branch from 84ef22b to d970fc0 Compare June 10, 2024 13:44
@albertchae albertchae changed the title moss/atomic browser with fetch pnpm deps atomic-browser: init at 0.37.0 Jun 10, 2024
@albertchae albertchae marked this pull request as ready for review June 10, 2024 13:50
@albertchae
Copy link
Contributor Author

Updated to use the upstream fetcher, finally ready for review!

@fricklerhandwerk fricklerhandwerk merged commit 167e61e into main Jun 10, 2024
74 checks passed
@fricklerhandwerk fricklerhandwerk deleted the moss/atomic-browser-with-fetch-pnpm-deps branch June 10, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants