-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes tags.yml from module and subworkflow template #2995
Conversation
tags.yml is no longer needed with newer testing workflows. This PR removes the file from the module and subworkflow templates and updates the linting tests to reflect this. Related to nf-core#2881
My ruff seems to lint differently to the default one, it's passing all pre-commits and linting but the code seems completely changed? |
if not is_pytest: | ||
old_test_dir = Path(subworkflow.base_dir, "tests", "subworkflows", subworkflow.component_name) | ||
if old_test_dir.is_dir(): | ||
subworkflow.failed.append(("test_old_test_dir", "old test directory exists", old_test_dir)) | ||
else: | ||
subworkflow.passed.append(("test_old_test_dir", "old test directory does not exist", old_test_dir)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines should be kept, it's testing that a subworkflow with nf-test doesn't have a directory with pytests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
tests/modules/lint.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deleted tests should be removed from tests/test_modules.py
, and the same from subworkflows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
@nf-core-bot fix linting please! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once tests pass :)
Are we planning to do a bulk PR to the models repo removing all tags.yml
files? Otherwise we could keep a listing test throwing a warning, advising to remove this file.
@nf-core-bot fix linting please! |
I hadn't thought this far ahead, perhaps a warning would be better so we can do it piecemeal. |
@mirpedrol can you see what's wrong with the tests here? I'm getting a lot of import errors on my laptop which don't seem to match the errors on Github. |
@adamrtalbot the tests which are failing now are also failing on the dev branch, I am working on finding what broke them, but it's not related to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files☔ View full report in Codecov by Sentry. |
@adamrtalbot all green now ✅ |
@mirpedrol still unrelated failed tests. Any ideas? |
tags.yml is no longer needed with newer testing workflows. This PR removes the file from the module and subworkflow templates and updates the linting tests to reflect this.
Note I've left tags in the templates because they're still useful.
Related to #2881
PR checklist
CHANGELOG.md
is updateddocs
is updated