Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where workflow can hang if the email parameter is set. #1745

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Fix bug where workflow can hang if the email parameter is set. #1745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fc4a7b
Fix bug where workflow can hang if the email parameter is set.
robsyme Dec 6, 2024
e68b414
Update CHANGELOG.md
robsyme Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [1702](https://github.com/nf-core/sarek/pull/1702) - Update nf-schema tests that were not failing on lenient mode
- [1712](https://github.com/nf-core/sarek/pull/1712) - Fix missing import statements on error messages when starting without samplesheet
- [1743](https://github.com/nf-core/sarek/pull/1743) - Add setup java 17 in GHA for latest Nextflow version
- [1745](https://github.com/nf-core/sarek/pull/1745) - Fix bug where workflow can hang if the email parameter is set

### Removed

Expand Down
4 changes: 3 additions & 1 deletion subworkflows/local/utils_nfcore_sarek_pipeline/main.nf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,8 @@ workflow PIPELINE_COMPLETION {
main:
summary_params = paramsSummaryMap(workflow, parameters_schema: "nextflow_schema.json")

def multiqc_report_list = multiqc_report.toList()

//
// Completion email and summary
//
Expand All @@ -195,7 +197,7 @@ workflow PIPELINE_COMPLETION {
plaintext_email,
outdir,
monochrome_logs,
multiqc_report.toList()
multiqc_report_list.getVal()
)
}

Expand Down
Loading